* Jon Hunter <jgchunter@xxxxxxxxx> [150211 09:43]: > > Thinking about this some more, I don't understand the dependency on the > DM_TIMER here. For an omap1 device, regardless of whether the DM_TIMERs > are enable or not, the device should be able to enter low power if the > 32K is enabled. Hence, shouldn't this have been !(CONFIG_OMAP_32K_TIMER) > above? Sounds about right, there are separate timers on omap1 and additional gp timers. There's no 32KiHz timer on 1510 variants, including 720 and 730. > Furthermore, you will get the above warning on a omap16xx only build if > you disable DM_TIMERs and keep MPU_TIMER enabled, which should be a > valid thing to do. > > Tony, I see you added the DM_TIMER dependency in commit > be26a008414414c69a4ae9fe9877401c3ba62c5a. I understand your motivation, > but why not just use !(CONFIG_OMAP_32K_TIMER) here? Bit 9 of the idlect1 > is only for the TIMCK clock that is used for the MPU timers and not the > DM_TIMERs. Hmm yes looks like you're right. That check be done based on !CONFIG_OMAP_32K_TIMER like you're saying. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
