On 02/06/15 11:37, Russell King - ARM Linux wrote: > On Fri, Feb 06, 2015 at 11:30:18AM -0800, Stephen Boyd wrote: >> Why don't we make the legacy lookup more specific and actually indicate >> "internal" for the con_id? Then the external clock would fail to be >> found, but we can detect that case and figure out that it's not due to >> probe defer, but instead due to the fact that there really isn't any >> mapping. It looks like the code is already prepared for this anyway. > We _could_, and that would solve this specific issue, but I'd suggest > coccinelle is used to locate any other similar instances of this. > > As I'm allergic to coccinelle (or coccinelle is allergic to me since > I never seem to be able to get it to do what I want...) > Great. I'd like to avoid adding clk_equal() until we actually need it, and I hope we don't ever need it. We've already got coccinelle in the works to find similar issues and it seems you and I have the same allergies because I can't get it to work for me right now. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html