Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Roger Quadros <rogerq@xxxxxx> [150129 03:34]:
> On 28/01/15 19:09, Tony Lindgren wrote:
> > * Roger Quadros <rogerq@xxxxxx> [150128 04:15]:
> >> On 28/01/15 04:19, Chanwoo Choi wrote:
> >>>>
> >>>> I still fail to understand that we need to call disable_irq() in .suspend() and
> >>>> enable_irq() in .resume()
> >>>>
> >>>> can you point me to any other drivers doing so?
> >>>
> >>> You can refer the suspend function in drivers/mfd/max14577.c or drivers/mfd/max77693.c.
> >>> The max14577_suspend() includes the detailed comment for why using disable_irq() in suspend function.
> >>>
> >>> In max14577 case, max14577_suspend() use disable_irq() function because of i2c dependency.
> >>> If max14577 device is wake-up from suspend state before completing the resume sequence
> >>> of i2c, max14577 may fail to read/write i2c communication.
> >>
> >> Thanks for this information. I will add disable/enable_irq() in suspend/resume().
> > 
> > Are the .dts changes safe for me to apply already?
> > 
> 
> Yes Tony, you can pick them. Thanks.

OK will apply the dts changes into omap-for-v3.20/dt thanks.
I have also the defconfig changes tagged, will apply those
a bit later probably as a fix after the driver is merged.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux