Felipe, This patch also remove some check no needed; this part - /* Check input parameters */ - CHECK_INPUT_PARAM(baseAddress, 0, RET_BAD_NULL_PARAM, RES_MBOX_BASE + - RES_INVALID_INPUT_PARAM); - CHECK_INPUT_PARAM(pIsFull, NULL, RET_BAD_NULL_PARAM, RES_MBOX_BASE + - RES_INVALID_INPUT_PARAM); - CHECK_INPUT_RANGE_MIN0(mailBoxId, HW_MBOX_ID_MAX, RET_INVALID_ID, - RES_MBOX_BASE + RES_INVALID_INPUT_PARAM); - And change the function to inline. Please let me know if you thing it needs something else. Regards, Fernando. -----Original Message----- From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Guzman Lugo, Fernando Sent: Tuesday, March 03, 2009 10:35 AM To: Felipe Contreras Cc: Pandita, Vikram; Kanigeri, Hari; Aguilar Pena, Leed; linux-omap@xxxxxxxxxxxxxxx Subject: RE: [OMAPZOOM][PATCH 5/5] DSPBRIDGE: Remove unnecessary checks in HW_MBOX_IsFull Hi Felipe, This patch is base on your patch about increase the performance waiting less and checking more the mail box. Regards, Fernando. -----Original Message----- From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] Sent: Tuesday, March 03, 2009 1:22 AM To: Guzman Lugo, Fernando Cc: Pandita, Vikram; Kanigeri, Hari; Aguilar Pena, Leed; linux-omap@xxxxxxxxxxxxxxx Subject: Re: [OMAPZOOM][PATCH 5/5] DSPBRIDGE: Remove unnecessary checks in HW_MBOX_IsFull On Tue, Mar 3, 2009 at 3:35 AM, Guzman Lugo, Fernando <x0095840@xxxxxx> wrote: > From db89674b7316d7490e71c131091758eb7ef0eca2 Mon Sep 17 00:00:00 2001 > From: Fernando Guzman Lugo <x0095840@xxxxxx> > Date: Wed, 25 Feb 2009 19:27:41 -0600 > Subject: [PATCH] DSPBRIDGE: Remove unnecessary checks in HW_MBOX_IsFull function > > This patch removes some unnecesarry checks in HW_MBOX_IsFull > function Is that all this patch is doing? > - u16 cnt = 10; > + u16 cnt = 1000; > - while (--cnt) { > - hwStatus = HW_MBOX_IsFull(resources.dwMboxBase, > - MBOX_ARM2DSP, &mbxFull); > - if (mbxFull) > - UTIL_Wait(1000); /* wait for 1 ms) */ > - else > - break; > - } > + while (--cnt && HW_MBOX_IsFull(resources.dwMboxBase, MBOX_ARM2DSP)) > + udelay(1); > + -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
