* David Miller <davem@xxxxxxxxxxxxx> [150113 13:08]: > From: Tony Lindgren <tony@xxxxxxxxxxx> > Date: Tue, 13 Jan 2015 11:54:16 -0800 > > > * Tom Lendacky <thomas.lendacky@xxxxxxx> [150113 11:51]: > >> On 01/13/2015 01:29 PM, Tony Lindgren wrote: > >> >We only use clk_get() to get the frequency, the rest is done by > >> >the runtime PM calls. Let's free the clock too. > >> > > >> >Cc: Brian Hutchinson <b.hutchman@xxxxxxxxx> > >> >Cc: Felipe Balbi <balbi@xxxxxx> > >> >Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > >> >--- > >> > drivers/net/ethernet/ti/davinci_emac.c | 1 + > >> > 1 file changed, 1 insertion(+) > >> > > >> >diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c > >> >index deb43b3..e9efc74 100644 > >> >--- a/drivers/net/ethernet/ti/davinci_emac.c > >> >+++ b/drivers/net/ethernet/ti/davinci_emac.c > >> >@@ -1881,6 +1881,7 @@ static int davinci_emac_probe(struct platform_device *pdev) > >> > return -EBUSY; > >> > } > >> > emac_bus_frequency = clk_get_rate(emac_clk); > >> >+ clk_put(emac_clk); > >> > >> The devm_clk_get call is used to get the clock so either a devm_clk_put > >> needs to be used here or just let the devm_ call do its thing and > >> automatically do the put when the module is unloaded. > > > > Thanks good catch, updated patch below. > > Please, once all the feedback has been addressed, repost the entire > series. Sure, will repost on Thursday in case there will be more comments. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
