On Thursday 26 February 2009, Mark Brown wrote:
> On Thu, Feb 26, 2009 at 11:48:36AM -0800, David Brownell wrote:
>
> > Updates since previous version: address feedback, simplify.
>
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> This looks good to merge to me - coincidentally I've got a use case for
> it lined up already. Might it be worth merging the MMC client along
> with this patch if the relevant maintainers are OK with that, could help
> get it in faster?
You mean, that example MMC code I sent? I think it's a bit
early to merge to mainline ... only the "generate ocr_mask"
call has really been verified. I'll send the updated version
along though.
I had thought about sending that with patches to convert the
omap_hsmmc driver over to the regulator framework. No skin
off my back if it goes with a different set of patches though.
> Just two very minor points which might be nice to fix at some point:
>
> > + cmin = INT_MIN;
> > + cmax = INT_MAX;
> > + }
> > +
> > + /* else require explicit machine-level constraints */
> > + else if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
>
> That indentation is going to catch some people out :)
Maybe.
> > + /* final: [min_uV..max_uV] valid iff constraints valid */
> > + if (max_uV < min_uV) {
> > + pr_err("%s: %s '%s' voltage constraints\n",
> > + __func__, "unsupportable", name);
> > + ret = -EINVAL;
>
> That style is going to hurt grepability for the error.
"grep unsupportable" ... :)
Sharing the primary string saves about three dozen bytes,
and I'm not keen on needless bloat.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
