On Mon, Nov 03, 2014 at 12:06:02PM -0600, Felipe Balbi wrote: > On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote: > > On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: > > > From: George Cherian <george.cherian@xxxxxx> > > > > > > Convert the driver to use gpiod_* API's. > > > > > > Reviewed-by: Roger Quadros <rogerq@xxxxxx> > > > Signed-off-by: George Cherian <george.cherian@xxxxxx> > > > Signed-off-by: Sekhar Nori <nsekhar@xxxxxx> > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > > --- > > > > I think it might be useful and appropriate to explain that and why > > you remove support for active-low pins, instead of hiding it in a > > seemingly unrelated patch. > > removed ? why removed ? gpio descs handle that for you, read the source > code. > Well, it for sure looks like it. Care to explain that in the patch, as well as how the platform data flag is used ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html