Felipe Balbi wrote: > Don't access pdev->resource[n].start directly, we > can use the resource helpers for that, makes the > code more readable. > [...snip...] > > - if (pdev->resource[1].flags != IORESOURCE_IRQ) { > - dev_dbg(&pdev->dev, "resource[1] is not IORESOURCE_IRQ\n"); > - retval = -ENOMEM; > - } > - Your patch description doesn't explain why you removed this code. Was it intentional? I didn't see that any of the helpers called below covered the case, but I didn't look too hard. Regards, - Josh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html