On Thu, Sep 25, 2014 at 03:02:07PM +0530, Lokesh Vutla wrote:
Perhaps the subject should simply be "use module_platform_driver", then
you can explain your motive for the change in the body as you already do.
> module_platform_driver_probe() prevents driver from requesting probe deferral.
> So using module_platform_drive() to support probe deferral.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@xxxxxx>
> ---
> Changes since V1:
> - New patch, seperated from patch 4/4.
> drivers/rtc/rtc-omap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 4e90b50..93c5424 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -397,7 +397,7 @@ static const struct of_device_id omap_rtc_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, omap_rtc_of_match);
>
> -static int __init omap_rtc_probe(struct platform_device *pdev)
> +static int omap_rtc_probe(struct platform_device *pdev)
> {
> struct resource *res;
> struct rtc_omap_dev *rtc_omap;
> @@ -601,6 +601,7 @@ static void omap_rtc_shutdown(struct platform_device *pdev)
> }
>
> static struct platform_driver omap_rtc_driver = {
> + .probe = omap_rtc_probe,
> .remove = __exit_p(omap_rtc_remove),
> .shutdown = omap_rtc_shutdown,
> .driver = {
You should also drop the .owner field of .driver, which is set by the
module_platform_driver macro.
> @@ -612,7 +613,7 @@ static struct platform_driver omap_rtc_driver = {
> .id_table = omap_rtc_devtype,
> };
>
> -module_platform_driver_probe(omap_rtc_driver, omap_rtc_probe);
> +module_platform_driver(omap_rtc_driver);
>
> MODULE_ALIAS("platform:omap_rtc");
> MODULE_AUTHOR("George G. Davis (and others)");
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
