On 09/22/2014 03:58 PM, Brian Norris wrote: > On Sat, Sep 20, 2014 at 05:53:16PM +0100, Ezequiel Garcia wrote: >> This fixes the following build error when omap2_nand is chosen built-in, >> and omap_elm is chosen as a module: >> >> drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config' >> drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config' >> drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config' >> drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page' >> >> Fix this by making omap_elm a 'bool' driver. > > Hmm, so we're sacrificing a "feature" (that omap2 + omap_elm can both be > built as modules) because we haven't solved one particular developer UI > inconsistency (that we don't prevent the config combination of > MTD_NAND_OMAP2=y and MTD_NAND_OMAP_BCH=m)? I wouldn't tend to sacrifice > the feature for the sake of a bad config. > FWIW, I agree with you, as already said to Roger. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar
Attachment:
signature.asc
Description: OpenPGP digital signature