On 09/19/2014 04:24 PM, Tomi Valkeinen wrote:
On 17/09/14 10:51, Jyri Sarha wrote:
On 09/17/2014 04:06 AM, Dave Airlie wrote:
On 17 September 2014 06:40, Jyri Sarha <jsarha@xxxxxx> wrote:
Changes since v2:
- Change compatible property from "ti,gpio-clock" to
"ti,gpio-gate-clock"
- Some minor cleanups
The code has a functional dependency to:
http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg109264.html
Without the above patch the audio card does not probe.
The code has been rebased on top of Linux 3.17-rc5. The patches
bellow, the above dependency, and couple of commits to add BBB HDMI
audio
support to omap2plus_defconfig can be pulled from:
https://github.com/jsarha/linux.git linux-master-bbb-hdmi-audio
How do you intend to get this merge, sending patchsets like this without
indication to maintainers on a merge strategy is kinda messy.
I'm not sure how maintained tilcdc is.
Well, it is used but AFAIK the people who have been working with it the
most have left TI. I think eventually someone at TI needs to take it
over, but I do not know anything about that.
I was hoping that because the change to tilcdc is quite minimal it could
go in via you. I am sure I could get a reviewed-by and tested-by from
from Darren how has bit more experience with tilcdc and maybe from Tomi
too if that helps. (Adding Tomi to cc).
The "drm/tilcdc: Add I2S HDMI audio config for tda998x"-patch itself
just adds the audio configuration to pda998x pdata and fills the swap,
and mirr parameters with default values (they are usually coming in hard
coded at the beginning of tda998x_create()).
I think Dave's point was that the series touches three different
subsystems, and you didn't give any thoughts about how this could be merged.
Must this be merged in one piece, because xxx depends on yyy etc? Can
these all be merged separately, via respective trees? If in one piece,
you could ask acks from Mr x and Mr y, for the parts they maintain. Etc.
And of course, it'd be good to include all the maintainers (At least
Mike was missing).
I think the clock patch could be handled totally separate, as it's in no
way related to HDMI. The video and audio part may be handled together,
if they have dependencies.
There should be no build time breakage no matter what is the merging
order. The BBB HDMI audio functionality simply does not work before all
the pieces are in.
1. The audio device does not probe if the ti,gpio-gate-clock is misssing.
2. The audio device probes, but there is no sound coming out if the
tilcdc_slave change is missing.
3. Without ASoC or DTS changes there is no audio device.
Best regards,
Jyri
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
