On 09:20-20140918, Tony Lindgren wrote: > * Nishanth Menon <nm@xxxxxx> [140918 09:12]: > > On 20:12-20140915, Tony Lindgren wrote: > > > Note that we can now use the CONFIG_GENERIC_CPUFREQ_CPU0, > > > so let's only enable that. > > > > > > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > > > --- > > > arch/arm/configs/omap2plus_defconfig | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > > > index fc63855..9d232a5 100644 > > > --- a/arch/arm/configs/omap2plus_defconfig > > > +++ b/arch/arm/configs/omap2plus_defconfig > > > @@ -43,6 +43,13 @@ CONFIG_ARM_APPENDED_DTB=y > > > CONFIG_ARM_ATAG_DTB_COMPAT=y > > > CONFIG_CMDLINE="root=/dev/mmcblk0p2 rootwait console=ttyO2,115200" > > > CONFIG_KEXEC=y > > > +CONFIG_CPU_FREQ=y > > > +CONFIG_CPU_FREQ_GOV_POWERSAVE=y > > > +CONFIG_CPU_FREQ_GOV_USERSPACE=y > > > +CONFIG_CPU_FREQ_GOV_ONDEMAND=y > > > +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y > > > +CONFIG_GENERIC_CPUFREQ_CPU0=y > > > +# CONFIG_ARM_OMAP2PLUS_CPUFREQ is not set > > > > With this > > we get performace as the default governor. > > > > could we use CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND as the default > > instead? on Many TI SoCs using Highest frequency is not really too nice > > of an idea for long periods of time. And not everything is upstream to > > support things optimially - example avs class 0, 1.5 ABB consolidation > > with cpufreq etc.. We definitely need thermal enabled as well for device > > safety needs. > > OK, sure. I've applied the following version with your changes folded > in. > > Regards, > > Tony > > 8< --------------- > From: Tony Lindgren <tony@xxxxxxxxxxx> > Date: Thu, 18 Sep 2014 09:01:07 -0700 > Subject: [PATCH] ARM: omap2plus_defconfig: Add cpufreq to defconfig > > Note that we can now use the CONFIG_GENERIC_CPUFREQ_CPU0, > so let's only enable that. Let's use CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND > as suggested by Nishant. > > And also let's enable thermal as explained by Nishant Menon: > > Many TI SoCs using Highest frequency is not really too nice of an idea for > long periods of time. And not everything is upstream to support things > optimially - example avs class 0, 1.5 ABB consolidation with cpufreq etc.. > We definitely need thermal enabled as well for device safety needs. > > Cc: Nishanth Menon <nm@xxxxxx> > [tony@xxxxxxxxxxx: updated per Nishant's suggestions] > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > > --- a/arch/arm/configs/omap2plus_defconfig > +++ b/arch/arm/configs/omap2plus_defconfig > @@ -43,6 +43,14 @@ CONFIG_ARM_APPENDED_DTB=y > CONFIG_ARM_ATAG_DTB_COMPAT=y > CONFIG_CMDLINE="root=/dev/mmcblk0p2 rootwait console=ttyO2,115200" > CONFIG_KEXEC=y > +CONFIG_CPU_FREQ=y > +CONFIG_CPU_FREQ_STAT_DETAILS=y > +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y > +CONFIG_CPU_FREQ_GOV_POWERSAVE=y > +CONFIG_CPU_FREQ_GOV_USERSPACE=y > +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y > +CONFIG_GENERIC_CPUFREQ_CPU0=y > +# CONFIG_ARM_OMAP2PLUS_CPUFREQ is not set > CONFIG_CPU_IDLE=y > CONFIG_BINFMT_MISC=y > CONFIG_PM_DEBUG=y > @@ -162,7 +170,9 @@ CONFIG_SENSORS_LM75=m > CONFIG_THERMAL=y > CONFIG_THERMAL_GOV_FAIR_SHARE=y > CONFIG_THERMAL_GOV_USER_SPACE=y > +CONFIG_CPU_THERMAL=y > CONFIG_TI_SOC_THERMAL=y > +CONFIG_TI_THERMAL=y > CONFIG_OMAP4_THERMAL=y > CONFIG_OMAP5_THERMAL=y > CONFIG_DRA752_THERMAL=y Acked-by: Nishanth Menon <nm@xxxxxx> -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
