On 17:56-20140917, Sebastian Andrzej Siewior wrote:
> I "forgot" to update the dtb and the kernel crashed:
> |Unable to handle kernel NULL pointer dereference at virtual address 0000002e
> |PC is at __clk_get_flags+0x4/0xc
> |LR is at ti_dt_clockdomains_setup+0x70/0xe8
>
> because I did not have the clock nodes. of_clk_get() returns an error
> pointer which is not checked here.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> v1…v2:
> add "%s __func__" to the added pr_err
>
> * Nishanth Menon | 2014-09-17 07:52:33 [-0500]:
> >
> >Could you add %s: __func__ as well - it kinda helps understand this
> >is part of clockdomain setup and not some driver cribbing that it did
> >not get some clock.
>
> As you wish.
>
> drivers/clk/ti/clockdomain.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
> index f1e0038d76ac..446481166ce9 100644
> --- a/drivers/clk/ti/clockdomain.c
> +++ b/drivers/clk/ti/clockdomain.c
> @@ -36,6 +36,12 @@ static void __init of_ti_clockdomain_setup(struct device_node *node)
>
> for (i = 0; i < num_clks; i++) {
> clk = of_clk_get(node, i);
> + if (IS_ERR(clk)) {
> + pr_err("%s: Failed get %s' clock nr %d (%ld)\n",
> + __func__, node->full_name, i,
> + PTR_ERR(clk));
> + continue;
> + }
Once the following is fixed (checkpatch --strict) feel free to add:
Acked-by: Nishanth Menon <nm@xxxxxx>
#65: FILE: drivers/clk/ti/clockdomain.c:35:
_node *node)
CHECK: Alignment should match open parenthesis
#71: FILE: drivers/clk/ti/clockdomain.c:40:
+ pr_err("%s: Failed get %s' clock nr %d (%ld)\n",
+ __func__, node->full_name, i,
total: 1 errors, 0 warnings, 1 checks, 16 lines checked
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
