On 09 Sep 11:35 AM, Roger Quadros wrote: > Ezequiel, > > On 09/08/2014 02:27 PM, Ezequiel Garcia wrote: > > This commit adds a new platform-data boolean property that enables use > > of a flash-based bad block table. This can also be enabled by setting > > the 'nand-on-flash-bbt' devicetree property. > > I'm not much aware of how on-flash-BBT works internally, but will it break things if > we keep on-flash-BBT "enabled" as the default option and add a DT property only to > explicitly disable the on-flash-BBT? > No, that wouldn't work because the DT property already exists and it works to enable the flash BBT when it's present. Documentation/devicetree/bindings/mtd/nand.txt Of course, we can add a new no-nand-on-flash-bbt, but I really don't see the point. Users can just put the property in all the devicetree board files where it's needed. And moreover, I don't want to change the default behavior of the driver; it's better to allow to *add* a new feature, if such feature is desired. Otherwise, users with some data in a flash's last blocks would be wiped and replaced with the BBT. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html