Re: ehci-omap patches (Was Re: [PATCH 0/5] [RESEND] lm8323 patches)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 20, 2009 at 3:23 PM, Gadiyar, Anand <gadiyar@xxxxxx> wrote:
>> Don't worry, you're not the only one TIred here...
>
> Grrr. I'm in no mood to take any TI puns right now. That was unwarranted.

Was it? I agree with Felipe (Balbi) there's more people tired of this
stuff. I don't know which way you would have preferred him to express
his frustration, or maybe you don't want any negative feedback at all.

>> > So here's the quick mail you want:
>> > "I may or may not be able to clean up this driver in the near future. Felipe
>> > Balbi graciously agress to do it for us. So I am pleased to  announce he will
>> > clean up this driver and send it upstream. If he needs any help with this, I
>> > will try to provide it to him (or anyone else for that matter) on a best-effort
>> > basis. Good luck."
>> >
>> >
>> > >
>> > > Anyways, I'll keep going with my cleanups and when I get a platform to
>> > > test ehci, I'll try to test the patches and keep going with the
>> > > workarounds.
>> >
>> > If you want help with testing, I can give it to you. If not, you can test
>> > it yourself - I couldn't care less.
>>
>> And you want me to agree with it ? I really was hoping we could work
>> together with TI but seems I'm the only one who still believes in that.
>
> I made that offer - so there is at least one other believer of working together.
> You're the one that wants to do this on your own - and I'm okay with that.

I don't know the history of this patch series, so perhaps I'm
misinterpreting this, but it looks like he submitted some patches and
you said it was the wrong way to do it and *you* would come up with a
proper patch.

A collaborative way to fix this issue would be to comment on the
specific pieces of code you would want changed, perhaps even re-send
the patches with the suggested changes so other people could review,
comment, test, etc. This would probably generate a few rounds of patch
series until it gets finally merged.

Instead you said you where going to provide a proper fix and never did
so. There might be valid reasons for not coming up with the patches
(like the difficulty of the task), but there's no excuse for the lack
of communication.

>> As you said yourself, you couldn't care less right ? You couldn't care
>> less if the driver works or not, you couldn't care less if we have good
>> omap support out of mainline kernel, you couldn't care less if the
>> driver is readable or not, etc etc etc.
>
> That's not true. I do care. It __is__ important to me that OMAP support goes
> to mainline. And I do not like it that it hasn't happened yet. Sorry.

Personally I find your position to be not collaborative at all. Do you
care or not? If you do, you could test Felipe's patches, review,
comment, rewrite, etc.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux