On 07 Sep 03:05 PM, pekon wrote: [..] > As ECC-scheme is selected in GPMC driver based on DTS settings, so > any mis-match is easily handled there. > Moreover, error will occur when we change ECC-scheme on-the-fly, > which is still not supported by framework, and require many other > updates if we plan to support that in near future. > So considering ECC-scheme as static configuration is a safe assumption. > > But surely you can drop new check in omap2_nand_ecc_check(), which > is already covered in @@gpmc_probe_nand_child(...) > > However, I leave it to you and rogerq@xxxxxx (as he currently > maintains OMAP NAND driver from TI side) to decide how to go about it. > As far as I can see, your proposal only cover the devicetree-probed case and it won't work for legacy boards. Given it seems we still support legacy, I'd say your proposal would break things. Not to mention that I still prefer to fail at probe time if the driver cannot deal with the selected ECC, and that's exactly what omap2_nand_ecc_check() does. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
