Re: [PATCH 2/2] OMAP: tsc2005: Change state machine to be more stable.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Phil,

>        r = request_irq(ts->spi->irq, tsc2005_ts_irq_handler,
> -                       IRQF_TRIGGER_FALLING | IRQF_DISABLED |
> -                       IRQF_SAMPLE_RANDOM, "tsc2005", ts);
> +                       (((TSC2005_CFR2_INITVALUE & TSC2005_CFR2_IRQ_MASK) ==
> +                         TSC2005_CFR2_IRQ_PENDAV)
> +                        ? IRQF_TRIGGER_RISING
> +                        : IRQF_TRIGGER_FALLING) |
> +                       IRQF_DISABLED | IRQF_SAMPLE_RANDOM, "tsc2005", ts);

No need to IRQF_SAMPLE_RANDOM, as it is already handled by input
subsystem. Please check input_report_event.

I had submitted earlier version of tsc2005.c to mainline, and we have
got couple of comments, I can see that you have fixed simple_strtoul
return related problem in sysfs in the first patch. I will send you
that thread link tomorrow.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux