Hi,
2013-11-19 16:59 GMT+01:00 Balaji T K <balajitk@xxxxxx>:
> On Tuesday 19 November 2013 09:19 PM, Tony Lindgren wrote:
>>
>> * Balaji T K <balajitk@xxxxxx> [131118 08:23]:
>>>
>>> On Monday 18 November 2013 05:45 PM, Andreas Fenkart wrote:
>>>>
>>>> 2013/11/18 Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>:
>>>>>
>>>>> On Mon, Nov 18, 2013 at 8:53 AM, Andreas Fenkart <afenkart@xxxxxxxxx>
>>>>> wrote:
>>>>>>
>>>>>> static int omap_hsmmc_card_detect(struct device *dev, int slot)
>>>>>> {
>>>>>> struct omap_hsmmc_host *host = dev_get_drvdata(dev);
>>>>>> @@ -452,10 +474,25 @@ static int omap_hsmmc_gpio_init(struct
>>>>>> omap_mmc_platform_data *pdata)
>>>>>> } else
>>>>>> pdata->slots[0].gpio_wp = -EINVAL;
>>>>>>
>>>>>> + if (gpio_is_valid(pdata->slots[0].gpio_cirq)) {
>>>>>> + pdata->slots[0].sdio_irq =
>>>>>> +
>>>>>> gpio_to_irq(pdata->slots[0].gpio_cirq);
>>>>>
>>>>>
>>>>> What is this? re-assign the platform data?
>>>>
>>>>
>>>> Seems like, I didn't pay attention to this.
>>>> Simply kept in line how the write protection/read only pins are managed.
>>>> I'd rather not change this part, or not changing it as part of adding
>>>> sdio IRQ support it.
>>>>
>>>> Maybe somebody else on the list can explain why the platform data
>>>> contains elements
>>>> that are modified during runtime.
>>>>
>>>> - set_power / get_ro function callbacks
>>>> - ocr_mask.
>>>>
>>> Hi,
>>>
>>> few params were passed via platform data in non-DT case and never cached
>>> in internal data structure, with non-dt support going away soon, I am
>>> planning to cleanup pdata usage in the driver when it gets to DT only
>>> support.
>>
any news on this?
I'd like to reuse generic mmc_of_parse, kind of difficult with the
current driver state
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
