Re: [PATCH 04/12] OMAPDSS: hdmi_audio: Integrated ASoC DAI component driver implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/06/14 15:26, Jyri Sarha wrote:
> On 06/27/2014 03:11 PM, Tomi Valkeinen wrote:
>> On 26/06/14 22:20, Jyri Sarha wrote:
> ...
>>> +static struct asoc_simple_card_info card_info = {
>>> +    .name = "HDMI",
>>> +    .card = "OMAPHDMI",
>>> +    .codec_dai.name = "hdmi-hifi",
>>> +};
>>
>> The above is not const. That, and the contents of the struct make me
>> wonder, what happens if we have two HDMI instances?
>>
>> I know the core driver doesn't work with multiple instances yet, but as
>> I mentioned, it has to be done sooner or later. And on the core driver
>> side it should be quite straightforward.
>>
>> I'd rather not introduce new restrictions for that goal.
>>
> 
> Ok, I'll alloc that with devm_kzalloc().

Do the strings in the struct need to be unique? If so, you probably need
to append something to them based on the hdmi device instance.

 Tomi


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux