On Friday 13 February 2009, Felipe Balbi wrote: > From: Felipe Balbi <felipe.balbi@xxxxxxxxx> > Date: Sat, 14 Feb 2009 00:34:56 +0200 > Subject: [PATCH] leds: lp5521: use sysfs_streq() > > instead of using strcmp() for comparing strings, > use sysfs_streq(). > > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> Yes, just like that. > --- > drivers/leds/leds-lp5521.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c > index b3ba52a..3e1ca31 100644 > --- a/drivers/leds/leds-lp5521.c > +++ b/drivers/leds/leds-lp5521.c > @@ -352,12 +352,14 @@ static ssize_t store_mode(struct device *dev, > > mutex_lock(&chip->lock); > > - if (!strncmp(buf, "run", 3)) > + if (sysfs_streq(buf, "run")) > lp5521_set_mode(chip, LP5521_MODE_RUN); > - else if (!strncmp(buf, "load", 4)) > + else if (sysfs_streq(buf, "load")) > lp5521_set_mode(chip, LP5521_MODE_LOAD); > - else if (!strncmp(buf, "direct", 6)) > + else if (sysfs_streq(buf, "direct")) > lp5521_set_mode(chip, LP5521_MODE_DIRECT_CONTROL); > + else > + len = -EINVAL; > > mutex_unlock(&chip->lock); > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html