On Fri, Feb 13, 2009 at 02:15:53PM -0800, David Brownell wrote: > So what's the plan for merging it then? I suspect it > relates to board-specific init ... regulator_register() > having changed signature for the 2.6.30 merge window, > and this FIXME remaining un-addressed: Yes, it'll need to be updated for mainline. I'd expect the updated version to be submitted via linux-kernel to myself and Liam (it's Liam who'd be doing the actual merge with Linus). > > /* FIXME board init code should provide init_data->driver_data > > * saying how to configure this regulator: how big is the > > * inductor (affects light PFM mode optimization), slew rate, > > * PLL multiplier, and so forth. > > */ > Maybe there should be a <linux/regulator/tps6235x.h> > header with that board-specific data, and the framework > data that's now thankfully not required to be held in > the platform_data. (That init_data->driver_data was I'd expect that would be done for whatever data is required - it's the standard thing and it's not new for regulator drivers either. I've no specific knowledge of this chip so I can't really assess what's vital to get implemented prior to merge and what can be added in further patches later. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
