On Thu, 12 Feb 2009 13:54:54 +0100 "Shargorodsky Atal (EXT-Teleca/Helsinki)" <ext-atal.shargorodsky@xxxxxxxxx> wrote: > This patch allows I2C_OMAP to be compiled as a module. > Only drivers/i2c/busses/i2c-omap.c can be compiled as a module, > but not arch/arm/plat-omap/i2c.c , so let the contents of i2c.c > to compile into the kernel if I2C_OMAP was selected to compile in > or as a module. > > Signed-off-by: Atal Shargorodsky <ext-atal.shargorodsky@xxxxxxxxx> > --- > arch/arm/plat-omap/Makefile | 3 +-- > arch/arm/plat-omap/i2c.c | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile > index 175bfd6..fe4738e 100644 > --- a/arch/arm/plat-omap/Makefile > +++ b/arch/arm/plat-omap/Makefile > @@ -4,7 +4,7 @@ > > # Common support > obj-y := common.o sram.o clock.o devices.o dma.o mux.o gpio.o \ > - usb.o fb.o io.o dss.o > + usb.o fb.o io.o dss.o i2c.o Can you base this on linux-omap? There is no dss there so patch doesn't apply. Generally I agree the patch since it fixes linking error when CONFIG_I2C_OMAP=m and arch/arm/plat-omap/i2c.o cannot be compiled as a module because it is for board initialization code. Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html