On Mon, 26 May 2014, Keerthy wrote:
> Add tps65917 PMIC support. tps65917 is a subset of palmas PMIC.
> Some of the register definitions and the interrupt mappings
> are different.
>
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> ---
> drivers/mfd/palmas.c | 177 ++++++++++++++++++++++++++++++++++++++++++++++++--
Much nicer. You just saved yourself(/the subsystem) 420 lines!
I have a single nit. Once it's fixed-up you can apply my:
Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> 1 file changed, 172 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index d280d78..e4684cc 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
[...]
> static const struct of_device_id of_palmas_match_tbl[] = {
> {
> .compatible = "ti,palmas",
> - .data = &palmas_features,
> + .data = &palmas_data,
> },
> {
> .compatible = "ti,tps659038",
> - .data = &tps659038_features,
> + .data = &tps659038_data,
> },
> + {
> + .compatible = "ti,tps65917",
> + .data = &tps65917_data,
> + },
> +
Please get rid of this line.
> { },
> };
> MODULE_DEVICE_TABLE(of, of_palmas_match_tbl);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
