On Thu, May 8, 2014 at 6:05 PM, Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote: [..] >> Further since not everything goes through the crossbar and some are >> direct mapped like your diagram, the correct fix is probably making it >> an irqchip and doing the interrupt controller parenting correctly in >> DT. >> >> That would take care of A), because users of such direct mapped >> interrupts will go through the GIC interrupt controller directly. >> >> It will also take care of B), because if writing to cross bar has no >> effect for a particular IRQ, or if those IRQs are hard-wired to >> something, as you said, then that something should go through the GIC >> directly. >> >> I can try to whip up something like this if it makes sense, let me know... >> > I have been ignoring this series considering they were just fixes > but you comments are like re-inventing wheel. Please read all > the old threads and comments from Thomas and me on why we took > approach and why it is not an irqchip. There is no need to complicate > it further. Are you talking about the discussion on this thread? http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/194318.html I didn't really get a sense that there was a common agreement that irqchip is not the way to go there. I can stand corrected if there was a common consensus that irqchip is not the right solution (with any specific comments why). There was a concern in the thread that making it irqchip doesn't help dma reuse the infrastructure, but that concern seems moot now that the driver is proposed to live in drivers/irqchip. Further, I don't think my comments are re-inventing anything because the brand-new bugs that are being found now weren't found then and my comments were more related to these bugs. As for complexity, it appears there will be signficant hacks coming up that are required to handle the corner cases by adding more lists and dt-properties. So its already on a complicated path.. Even with such hacks, Nishanth pointed out that the implementation can break. Its already like a deck of cards in my opinion and complicates things for everyone using it. You said you hadn't gone through the fixes in this series, you should go over them and see the new lists added to skip and reserve various things. thanks, -Joel -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
