On Wed, Apr 30, 2014 at 7:34 PM, Suman Anna <s-anna@xxxxxx> wrote: > The HwSpinlock core requires a base id for registering a bank > of hwspinlocks. This base id needs to be unique across multiple > IP instances of a hwspinlock device, so that each hwlock can be > represented uniquely in a system. > > Support has been added to represent this in DT through a common > property 'hwlock-base-id', and retrieve the value through a core > OF helper function, of_hwspin_lock_get_base_id(). The representation > in DT provides a uniform way of assigning a fixed base value for a > hwspinlock device across different SoCs. > > Signed-off-by: Suman Anna <s-anna@xxxxxx> > --- > Documentation/devicetree/bindings/hwlock/hwlock.txt | 6 ++++++ > drivers/hwspinlock/hwspinlock_core.c | 21 +++++++++++++++++++++ > include/linux/hwspinlock.h | 1 + > 3 files changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwlock/hwlock.txt b/Documentation/devicetree/bindings/hwlock/hwlock.txt > index 32381cc..d538a9b 100644 > --- a/Documentation/devicetree/bindings/hwlock/hwlock.txt > +++ b/Documentation/devicetree/bindings/hwlock/hwlock.txt > @@ -18,6 +18,12 @@ Common properties: > property is needed on hwlock devices, where the number > of supported locks within a hwlock device cannot be > read from a register. > +- hwlock-base-id: An unique base Id for the locks for a particular hwlock > + device. This property is mandatory ONLY if a SoC has > + several hwlock devices. > + > + See documentation on struct hwspinlock_pdata in > + include/linux/hwspinlock.h for more details. The documentation cannot refer to kernel files. Generally, creating a global number space like this would not be accepted, but I don't really have any better idea here. Please put all binding docs in 1 patch and copy all the DT binding maintainers. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
