On 28/04/14 14:17, Jingoo Han wrote:
> On Monday, April 28, 2014 7:54 PM, Masanari Iida wrote:
>>
>> Fix two format string mismatch in display-sysfs.c
>>
>> Signed-off-by: Masanari Iida <standby24x7@xxxxxxxxx>
>> ---
>> drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display-
>> sysfs.c
>> index 5a2095a..5928bc9 100644
>> --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
>> +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
>> @@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev,
>> if (!dssdev->driver->get_rotate)
>> return -ENOENT;
>> rotate = dssdev->driver->get_rotate(dssdev);
>
> According to 'struct omap_dss_driver', get_rotate() returns 'u8'.
> Then, how about changing the type of 'rotate' variable from 'int'
> to 'u8' as below?
>
> --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
> +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
> @@ -180,7 +180,7 @@ static ssize_t display_rotate_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> struct omap_dss_device *dssdev = to_dss_device_sysfs(dev);
> - int rotate;
> + u8 rotate;
> if (!dssdev->driver->get_rotate)
> return -ENOENT;
> rotate = dssdev->driver->get_rotate(dssdev);
>
>
> Best regards,
> Jingoo Han
>
>> - return snprintf(buf, PAGE_SIZE, "%u\n", rotate);
>> + return snprintf(buf, PAGE_SIZE, "%d\n", rotate);
>> }
>>
>> static ssize_t display_rotate_store(struct device *dev,
>> @@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev,
>> if (!dssdev->driver->get_mirror)
>> return -ENOENT;
>> mirror = dssdev->driver->get_mirror(dssdev);
>> - return snprintf(buf, PAGE_SIZE, "%u\n", mirror);
>> + return snprintf(buf, PAGE_SIZE, "%d\n", mirror);
>> }
And get_mirror returns a bool, not int, so I guess that could be fixed also.
Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
