On Tuesday 29 April 2014 01:59:20 Javier Martinez Canillas wrote: > This driver is also used by OMAP1. Even when disabling GPIO_OMAP on that > platform doesn't cause a build error since no function defined in the driver is > used directly by platform code, I think that we always want this driver on OMAP1 > too. > > > However, it seems entirely reasonable to include the driver in build tests > > on other platforms, so we should also allow building it for COMPILE_TEST > > builds and select the required GENERIC_IRQ_CHIP that may not already be > > enabled on other platforms. > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > > index c58b828..c8c42be 100644 > > --- a/drivers/gpio/Kconfig > > +++ b/drivers/gpio/Kconfig > > @@ -244,9 +244,10 @@ config GPIO_OCTEON > > family of SOCs. > > > > config GPIO_OMAP > > - bool "TI OMAP GPIO support" > > + bool "TI OMAP GPIO support" if COMPILE_TEST && !ARCH_OMAP2PLUS > > So this should be: > > + bool "TI OMAP GPIO support" if COMPILE_TEST && !ARCH_OMAP2PLUS && > !ARCH_OMAP1 > Well, if COMPILE_TEST is disabled on OMAP1, the option is already hidden and enabled in my version. It seems reasonable to me to allow compile-testing OMAP1 without the GPIO driver, while a kernel running on OMAP1 should always have COMPILE_TEST disabled. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
