Re: [PATCH 11/23] ARM: dts: omap5-uevm.dts: add tca6424a

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 04/24/2014 06:33 PM, Tomi Valkeinen wrote:

omap5-uevm has a tca6424a I/O expander. Add it to the .dts file.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
Cc: Tony Lindgren <tony@xxxxxxxxxxx>
---
   arch/arm/boot/dts/omap5-uevm.dts | 7 +++++++
   1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/omap5-uevm.dts
b/arch/arm/boot/dts/omap5-uevm.dts
index 3b99ec25b748..9e7581eaeb23 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -434,6 +434,13 @@
       pinctrl-0 = <&i2c5_pins>;

       clock-frequency = <400000>;
+
+    tca6424a: tca6424a@22 {

    The ePAPR standard [1] says: "The name of a node should be somewhat
generic,
reflecting the function of the device and not its precise programming
model.
If appropriate, the name should be one of the following choices:
[...]
    - gpio;"

Right. I wonder what the name should be... "gpio" is out, as the name
should be more specific.

   No, it's not out. The name should be "gpio@22", I think it would be unique.

We already have gpio1-8, which are the gpio
banks from the SoC.

I don't understand why you are indexing the names while you probably have the address part after @ that makes them unique already.

  Tomi

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux