On Tue, Apr 22, 2014 at 3:31 PM, <yegorslists@xxxxxxxxxxxxxx> wrote:
> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
>
> This patch implements gpio_chip's get_direction() routine, that
> lets other drivers get particular GPIOs direction using
> struct gpio_desc.
>
> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> Acked-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> ---
> Changes:
> v2: rework return value calculation
(...)
I don't see why this need to be a broken-out function? Can it not
be factored into gpio_get_direction?
> +static int _get_gpio_direction(struct gpio_bank *bank, int gpio)
> +{
> + void __iomem *reg = bank->base;
> + u32 l;
> +
> + reg += bank->regs->direction;
> + l = (readl_relaxed(reg) >> gpio);
> +
> + return (l & 0x00000001);
Rewrite the last two statements like this:
#include <linux/bitops.h>
return !!(readl_relaxed(reg) & BIT(gpio));
> +static int gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> +{
> + struct gpio_bank *bank;
> + unsigned long flags;
> + int dir;
> +
> + bank = container_of(chip, struct gpio_bank, chip);
> + spin_lock_irqsave(&bank->lock, flags);
> + dir = _get_gpio_direction(bank, offset);
> + spin_unlock_irqrestore(&bank->lock, flags);
> + return dir;
> +}
So since _get_gpio_direction is never called from unlocked context,
can it not just be part of this function then?
(I make a mental note to prefix all functions in this driver
with omap_*....)
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
