Re: [PATCH] ARM: OMAP2+: don't try to register the main clock twice.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

thanks for the reply!

> > If omap_device_alloc is given 2 or more "struct omap_hwmod" it will try
> > to register the 'main_clk' of each of them with the same alias - "fck" -
> > against the same device.  This fails. So to avoid a warning, don't even
> > try.
> > 
> > Signed-off-by: NeilBrown <neilb@xxxxxxx>
> > [wsa: ported to top-of-tree]
> > Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxxxxxxxxx>
> 
> What devices and hwmods cause this warning on AM335x?   Ideally, there 
> should only be one hwmod per device.  Usually when multiple hwmods are 
> stacked up for a device, it means that something isn't right - either the 
> hwmod data, or the device driver itself. 

I applied the patch because of the edma driver DT entry for the am335x.
Check am33xx.dtsi, it has multiple hwmods. I also get this message
printed for the d_can driver with am335x; they have two entries in
drivers/clk/ti/clk-33xx.c. Probably as a workaround to match the desired
clock name for the d_can driver? Didn't really investigate yet.

> In the specific context of this patch, the problem would be: what if the 
> two hwmods have different main_clk entries?  Which one should be 
> associated with the "fck" alias?

Sadly, I am in a board bringup phase and can't really contribute to the
discussions. Lots of other issues to tackle at the moment.

All the best,

   Wolfram

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux