On Thursday 13 March 2014 06:07 AM, Nishanth Menon wrote: > On 03/12/2014 04:59 PM, Santosh Shilimkar wrote: >> On Thursday 13 March 2014 05:43 AM, Nishanth Menon wrote: >>> Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if >>> CONFIG_PM is enabled, else, disabling CONFIG_PM results in build >>> failure complaining about the following: >>> arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary': >>> :(.text+0x8a70): undefined reference to `pm44xx_errata' >>> >> Not entirely accurate since CPU hotplug doesn't depend on CONFIG_PM > > Just reporting the build error here. >> >>> Fixes: c962184 (ARM: OMAP4: PM: add errata support) >>> Reported-by: Tony Lindgren <tony@xxxxxxxxxxx> >>> Signed-off-by: Nishanth Menon <nm@xxxxxx> >>> --- >>> >>> Patch based on: v3.14-rc6 >>> Reported originally with a randconfig defconfig: http://slexy.org/view/s21U7eF4k1 >>> >> But without the PM sleep code, hotplug won't work either. > yep - agreed, >> SO I think its ok assumption in this particular case > > Can I take that as an Ack here? or would you suggest any improvements? > yep. Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
