Hi, On Friday 13 December 2013 11:06 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I <kishon@xxxxxx> [131213 03:57]: >> On Friday 13 December 2013 04:57 PM, Belisko Marek wrote: >>> Kishon can you please comment on that? Would be possible to get your >>> patch to 3.13 (I seen some comments from Felipe). >> >> I'm not sure as my patch modifies all the board files. There was initially some >> confusion w.r.t when the board files will be dropped. But since board files >> will still be there in 3.13, I'd recommend my patch [1] to be taken. Anyways >> if you have tested my patch (series), pls give your Tested-by. >> >> Tony, summary of the issue.. >> After the platform devices are created using PLATFORM_DEVID_AUTO, the >> device names given in usb_bind_phy (in board file) does not match with >> the actual device name causing the USB PHY library not to return the >> PHY reference when the MUSB controller request for the PHY in the non-dt boot >> case. So removed creating platform devices using PLATFORM_DEVID_AUTO in >> omap2430.c. So had to make the corresponding changes in board files. > > OK. Can you please repost with a proper commit id for what caused the > regression and summararize why it should be fixed this way. Something like: > > Commit abcd1234 (usb: blah foo bar) caused blah blah blah. Fix the issue > with blah blah blah. Note that the board-*.c files will be removed soon, > but for v3.13 we still support both legacy booting and device tree based > booting and need to fix it. huh.. I think we can have a much simpler fix. All this binding in board file was introduced to support platforms that has multiple PHYs of the same type. But musb/omap2430.c serves platforms that has only one PHY of a particular type. We can just go back to usb_get_phy(enum usb_phy_type type) instead of 'usb_get_phy_dev' in omap2430.c. Felipe, what do you think? Cheers Kishon > > Regards, > > Tony > >> [1] -> http://lists.scusting.com/index.php?t=msg&th=375579&start=0&S=Google -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
