Chao Xu <caesarxuchao@xxxxxxxxx> writes: > From: Felipe Balbi <balbi@xxxxxx> > > try to keep gpio block suspended as much as possible. > Tested with pandaboard and a sysfs exported gpio. > > Signed-off-by: Felipe Balbi <balbi at ti.com> > > [caesarxuchao@xxxxxxxxx : Refreshed against v3.12-rc5, and added > revision check to enable aggressive pm_runtime on OMAP4-only. Because > am33xx_gpio_sysc.idlemodes seems to be wrongly marked as > SIDLE_SMART_WKUP, which might cause missed interrupts with this patch. > Tested on Pandaboard rev A2.] > Signed-off-by: Chao Xu <caesarxuchao@xxxxxxxxx> I have several problems with this patch. First, the changelog is missing a lot of information. In particular, nowhere is it described what problem is this patch addressing and how this patch addresses that problem. Second, I don't see any mention of off-mode, and I suspect there are issues with off-mode here that are not being addressed. Also, I *really* don't like any approach that is targetted at a single SoC. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
