> > The code looks mostly fine, but the implementation of the commit logs > > seems lazy. Please submit a v3 using coherent sentences with full > > explanations and correct punctuation. > > example ? All of your commit messages. > that macro just helps removing some extra ^- Sentences start with an uppercase character. > line of code and hides ffs() calls. > > while at that, also fix a variable shadowing ^- Sentences start with an uppercase character. > bug where 'int irq' was being redeclared inside > inner loop while it was also argument to interrupt > handler. < --------------- 50 chars ----------------- > Please use the full 72 char (or there abouts) width of the buffer. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html