Re: [PATCH] ARM: OMAP: board-omap3beagle: set i2c-3 to 100kHz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Jan 23, 2009, at 4:48 AM, Koen Kooi wrote:


Op 23 jan 2009, om 10:52 heeft David Brownell het volgende geschreven:

On Friday 23 January 2009, Koen Kooi wrote:

Op 15 jan 2009, om 20:30 heeft Koen Kooi het volgende geschreven:

From: Koen Kooi <koen@xxxxxxxxxxxxxxx>

Changing it to 100kHz is needed to make more devices works properly.
Controlling the TI DLP Pico projector[1] doesn't work properly at
400kHz, 100kHz and lower work fine. EDID readout is unaffected by
this change.

[1] http://focus.ti.com/dlpdmd/docs/dlpdiscovery.tsp?sectionId=60&tabId=2234

Signed-off-by: Koen Kooi <koen@xxxxxxxxxxxxxxx>

Any comments on this patch?

I2C-3 is only used for talking on DVI, right?
Which means EDID ... and maybe DLP/Pico, unless
someone uses it as an I2C adapter.  (Which some
folk hack together on PCs...)

Seems harmless to me, but I'd add a comment
explaining why just 100 MHz.  (The Pico manual
says 400 KHz should work.)

The updated manual will say 400kHz won't work, the TI DLP engineers were the ones that designed the pico that pointed the i2c speed problem out to me :) I'd be happy to change the patch if needed, but I think the updated manual will take care of most issues.

regards,

Koen

Given that this port is only used on the DVI port for the BeagleBoard, I believe it is appropriate to set it to 100kHz as Koen has done.






- Dave



regards,

Koen





---
arch/arm/mach-omap2/board-omap3beagle.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/ mach-
omap2/board-omap3beagle.c
index fe97bab..f279404 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -227,7 +227,7 @@ static int __init omap3_beagle_i2c_init(void)
#ifdef CONFIG_I2C2_OMAP_BEAGLE
	omap_register_i2c_bus(2, 400, NULL, 0);
#endif
-	omap_register_i2c_bus(3, 400, NULL, 0);
+	omap_register_i2c_bus(3, 100, NULL, 0);
	return 0;
}

--
1.5.6.3


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux