Hi Enric,
Thanks a lot for fixing this.
When adding NAND support for the IGEP boards I used as a base the
example from Documentation/devicetree/bindings/mtd/gpmc-nand.txt and I
wrongly assumed that bch8 was also the ECC scheme used in the legacy
IGEP board file. Sorry for the inconvenience.
On Sun, Dec 1, 2013 at 12:23 PM, Enric Balletbo i Serra
<eballetbo@xxxxxxxxx> wrote:
> Legacy board files for IGEP Processor Boards used 1-bit Hamming ECC layout but
> new DT uses BCH8 software layout. This breaks the backward compatibility for
> people that used board files before and switch to DT and have the problem that
> they can't flash the rootfs using the bootloader.
>
> This patch sets the ECC layout to 1-bit Hamming ECC in order to maintain this
> compatibility.
>
> Reported-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
> Reported-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@xxxxxxxxx>
> ---
> arch/arm/boot/dts/omap3-igep0020.dts | 2 +-
> arch/arm/boot/dts/omap3-igep0030.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
> index d5cc792..4229e94 100644
> --- a/arch/arm/boot/dts/omap3-igep0020.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020.dts
> @@ -116,7 +116,7 @@
> linux,mtd-name= "micron,mt29c4g96maz";
> reg = <0 0 0>;
> nand-bus-width = <16>;
> - ti,nand-ecc-opt = "bch8";
> + ti,nand-ecc-opt = "ham1";
>
> gpmc,sync-clk-ps = <0>;
> gpmc,cs-on-ns = <0>;
> diff --git a/arch/arm/boot/dts/omap3-igep0030.dts b/arch/arm/boot/dts/omap3-igep0030.dts
> index 525e6d9..9043e97 100644
> --- a/arch/arm/boot/dts/omap3-igep0030.dts
> +++ b/arch/arm/boot/dts/omap3-igep0030.dts
> @@ -59,7 +59,7 @@
> linux,mtd-name= "micron,mt29c4g96maz";
> reg = <0 0 0>;
> nand-bus-width = <16>;
> - ti,nand-ecc-opt = "bch8";
> + ti,nand-ecc-opt = "ham1";
Just a note that this binding property got renamed for v3.13 on
commit c66d039197e42af8867e5d0d9b904daf0fb9e6bc
Author: Pekon Gupta <pekon@xxxxxx>
Date: Thu Oct 24 18:20:18 2013 +0530
mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes
so users using current v3.12 kernel or older should use
ti,nand-ecc-opt = "sw";
instead.
>
> gpmc,sync-clk-ps = <0>;
> gpmc,cs-on-ns = <0>;
> --
> 1.8.1.2
>
> --
Acked-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
