Re: [PATCH] usb: musb: Fix unstable init of OTG_INTERFSEL.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Nov 22, 2013 at 10:37:49AM +0100, anaumann@xxxxxxxxxxxxxx wrote:
> From: Andreas Naumann <anaumann@xxxxxxxxxxxxxx>
> 
> This is a hard to reproduce problem which leads to non-functional USB-OTG port in 0.1%-1% of all boots.
> Tracked it down to commit e25bec160158abe86c276d7d206264afc3646281, which introduces save/restore of OTG_INTERFSEL over suspend.
> Since the resume function is also called early in driver init, it uses a non-initialized value (which is 0 and a non-supported setting in DM37xx for INTERFSEL).
> Shortly after the correct value is set. Apparently this works most time, but not always.
> 
> The fix is to initialize the value, BEFORE being written in the resume function.
> 
> Signed-off-by: Andreas Naumann <anaumann@xxxxxxxxxxxxxx>

please resend with linux-usb in Cc as well. Also make sure that your
lines (in commit log) aren't over 72 characters.

thanks

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux