On Tue, Jan 20, 2009 at 11:06:00AM -0800, David Brownell wrote: > On Tuesday 13 January 2009, David Brownell wrote: > > + /* adjust to match supported range, fail if out of range */ > > + if (min_uV < info->min_uV) > > + min_uV = info->min_uV; > > + if (max_uV > info->max_uV) > > + max_uV = info->min_uV; > On second thought, those particular checks would be better > handled by updating the board-level constraints in probe(). If doing this you should complain loudy - it may be better to just refuse to run rather than fixing them up in case something else is noticably wrong with them and they might be risky. > That will let this driver not worry about the chip's hard > limits in set_voltage(), and will ensure that the constraints > listed in sysfs are accurate ... in the sense of not lying > about what the actual system capabilities are. Indeed - if the constraints are accurate there should be no need to validate them at all. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
