On Tue, Jan 13, 2009 at 04:59:10PM +0200, Tony Lindgren wrote:
> > +int tps_6235x_read_reg(struct i2c_client *client, u8 reg, u8 *val)
> The the read/write_reg should be in drivers/mfd somewhere.
Is this a multi-function device? If so then there should be a similar
structure to the TWL4030 drivers should be used with the function
drivers all being platform drivers instantiated by the core (either
manually or via the MFD helpers). The regulator driver was a regular
I2C device, suggesting that all the device does is regulation, in which
case the register I/O functions should be in there.
> > + platform_device_register(pdev);
> > +#if defined(CONFIG_OMAP3EVM_PR785)
> > + if (bus_id == 1) {
> > + omap_i2c_register_child(pdev, "vdd2_consumer", \
> > + &vdd2_platform_device);
> > + omap_i2c_register_child(pdev, "vdd1_consumer", \
> > + &vdd1_platform_device);
> > + }
> > +#endif
> > + return 0;
> > }
> Argh, i2c-omap.c is the _bus_ driver, not i2c device! Please move
> the above code to drivers/mfd somewhere.
There should be no need to do this at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
