Re: [REVIEW PATCH 10/14] OMAP: CAM: Add ISP gain tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 12 Jan 2009 20:03:30 -0600
"Aguirre Rodriguez, Sergio Alberto" <saaguirre@xxxxxx> wrote:

> This adds the OMAP ISP gain tables. Includes:
> * Blue Gamma gain table
> * CFA gain table
> * Green Gamma gain table
> * Luma Enhancement gain table
> * Noise filter gain table
> * Red Gamma gain table
> 
> Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
> ---
>  drivers/media/video/isp/bluegamma_table.h    | 1040 ++++++++++++++++++++++++++
>  drivers/media/video/isp/cfa_coef_table.h     |  592 +++++++++++++++
>  drivers/media/video/isp/greengamma_table.h   | 1040 ++++++++++++++++++++++++++
>  drivers/media/video/isp/luma_enhance_table.h |  144 ++++
>  drivers/media/video/isp/noise_filter_table.h |   79 ++
>  drivers/media/video/isp/redgamma_table.h     | 1040 ++++++++++++++++++++++++++
>  6 files changed, 3935 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/media/video/isp/bluegamma_table.h
>  create mode 100644 drivers/media/video/isp/cfa_coef_table.h
>  create mode 100644 drivers/media/video/isp/greengamma_table.h
>  create mode 100644 drivers/media/video/isp/luma_enhance_table.h
>  create mode 100644 drivers/media/video/isp/noise_filter_table.h
>  create mode 100644 drivers/media/video/isp/redgamma_table.h

Hmm... patch 06/14 needs this one to compile... This patch should have been added before 06/14...

Also, this is just a series of magic numbers. Could you please put a generic
comment about the meaning of those numbers, better specifying what those tables
are meant to and how are they handled? 

Also, instead of just having a magic sequence of numbers, is better to have the
struct definition there, and put it into a nicer format.

So, instead of:

/*
 * CFA Filter Coefficient Table
 *
 */
static u32 cfa_coef_table[] = {
#include "cfa_coef_table.h"
};

You should do something like:

/*
 * Color Filter Array (CFA) Coefficient Table
 *
 * This table specifies coefficients for a filter that ...
 *
 */
static u32 cfa_coef_table[] = {
	0,   247,   0, 244, 247,  36,  27,  12,
	0,    27,   0, 250, 244,  12, 250,   4,

	...

};

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux