* Gupta, Ajay Kumar <ajay.gupta@xxxxxx> [090113 06:33]: > > -----Original Message----- > > From: Felipe Balbi [mailto:me@xxxxxxxxxxxxxxx] > > Sent: Tuesday, January 13, 2009 3:57 AM > > To: Gupta, Ajay Kumar > > Cc: linux-omap@xxxxxxxxxxxxxxx; david-b@xxxxxxxxxxx; felipe.balbi@xxxxxxxxx > > Subject: Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming > > > > On Fri, Jan 09, 2009 at 10:09:06AM +0530, Ajay Kumar Gupta wrote: > > > Mode bit should be set based on function parameter "mode" of > > > configure_channel() function. > > > > > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx> > > > > Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > > > > > --- > > > Original version of this patch is at, > > > http://marc.info/?l=linux-usb&m=123141793611158&w=2 > > > > tony, this should go to l-o > > Tony, > > Please use below version refreshed against latest l-o git. Thanks, pushing today. Tony > > -Ajay > =========================== cut here ====================================== > Mode bit should be set based on function parameter "mode" of > configure_channel() function. > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx> > Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > --- > drivers/usb/musb/musbhsdma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c index 75b15ce..4394bd3 100644 > --- a/drivers/usb/musb/musbhsdma.c > +++ b/drivers/usb/musb/musbhsdma.c > @@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel, > csr |= MUSB_HSDMA_BURSTMODE_INCR4; > > csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT) > - | MUSB_HSDMA_MODE1 > + | (mode ? MUSB_HSDMA_MODE1 : 0) > | MUSB_HSDMA_ENABLE > | MUSB_HSDMA_IRQENABLE > | (musb_channel->transmit > -- > 1.5.6 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
