On Mon, Jan 12, 2009 at 05:35:28PM +0200, Tony Lindgren wrote: > Well at least you could remove some parens. > How about (dma_trigger / 32) << 19 instead? Oh, and further to my previous reply there is also the general principle of writing what you mean. So, if you mean to clear the least significant 5 bits, write it as a mask with ~0x1f, not as a divide. And no, you don't need ~(0x1f) - the parens there are pure noise. ~0x1f does just as well and isn't in any way confusing to the compiler. To put it another way, parens around a single value are completely meaningless. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
