Re: [PATCH 1/2] ARM: OMAP: Fix missing includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 10, 2009 at 12:49:26PM -0800, David Brownell wrote:
> On Saturday 10 January 2009, Samuel Ortiz wrote:
> > > --- a/drivers/mfd/twl4030-core.c
> > > +++ b/drivers/mfd/twl4030-core.c
> > > @@ -38,6 +38,7 @@
> > >  #include <linux/i2c.h>
> > >  #include <linux/i2c/twl4030.h>
> > >  
> > > +#include <mach/cpu.h>
> > That will break the build on !ARM for this driver.
> 
> What needs to happen with twl4030-core.c is IMO this:
> 
>  - Near term:
>      * revert 6354ab5c63bc986bf539026a1b289cc142f6e87c
>        and just make the driver depend on HAVE_CLK
Yep, I'll do that afer the merge window.

>      * #ifdef CONFIG_ARM do the #include <mach/cpu.h>
Not too pretty, but a good enough compromise for me.
I'll push that.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux