> Hi Hans, > >> >> I'm not going to spam the list with these quite big patches. Just go to >> http://linuxtv.org/hg/~hverkuil/v4l-dvb-ng/ and click on the 'raw' link >> after each change to see the patch. Most of these changes are just >> boring i2c driver conversions. > > It is hard to review these patches from this link, as if you submit > the patch to ML then someone can just give inline comments to your > patch, otherwise reviewer has to copy that code which he/she wants to > comment while replying and not easy to track too. I don't know size > limit of this v4l2 ML, but linux-kernel ML can receive somewhat big > patches I believe. The V4L2 ML is fairly limited. I'm pretty sure it can't handle the ivtv change (70+ kB). I can do this for the two changes that actually add the new code and for one of the i2c conversion tonight (this webmail client messes up the layout). Personally I dislike reviewing large patches that are part of an email. Smaller ones are OK, but large patches are hard to read. Much easier to review with a decent editor. > >> >> We are adding to the v4l core, but the changes do not affect existing >> v4l drivers let alone other subsystems. Although I should probably have >> added the omap list. > > OMAP + soc-camera + v4l2-int-* community would be more interested to > see these patches as they need to change their sensor/controller > drivers to adapt your changes. I'll add the linux-omap mailinglist when I repost tonight. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html