RE: [PATCH 2/2] TVP514x V4L int device driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hans,
>
> Thanks,
> Vaibhav Hiremath
>
>> -----Original Message-----
>> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
>> owner@xxxxxxxxxxxxxxx] On Behalf Of Trilok Soni
>> Sent: Monday, November 24, 2008 2:13 PM
>> To: Hans Verkuil
>> Cc: video4linux-list@xxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx;
>> davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx
>> Subject: Re: [PATCH 2/2] TVP514x V4L int device driver support
>>
>> Hi Hans,
>>
>> >
>> > The v4l2-int-device.h stuff should never have been added. Ditto
>> for
>> > parts of the soc-camera framework that duplicates v4l2-int-
>> device.h. My
>> > new v4l2_subdev support will replace the three methods of using
>> i2c
>> > devices (or similar) that are currently in use. It's exactly to
>> reduce
>> > the confusion that I'm working on this.
>> >
>> > It's been discussed before on the v4l mailinglist and the relevant
>> > developers are aware of this. It's almost finished, just need to
>> track
>> > down a single remaining oops.
>>
>> Right, I will wait for your updates.
>>
>> I am planning to send omap24xxcam and ov9640 drivers (now deleted)
>> available from linux-omap tree after syncing them with latest
>> linux-2.6.x tree, and the whole driver and the sensor is written
>> using
>> v4l2-int-device framework. I am going to send it anyway, so that it
>> can have some review comments.
>>
> [Hiremath, Vaibhav] Is your current development accessible through
> linuxtv.org? Can you share it with us, so that we can have a look into it?
> Which driver you are migrating to new interface (which I can refer to as a
> sample)?

Yes, it is. Look at these two trees:

http://linuxtv.org/hg/~hverkuil/v4l-dvb-media2
http://linuxtv.org/hg/~hverkuil/v4l-dvb-ng

The second tree is meant to be merged into the v4l-dvb master, but is
missing the converted ivtv driver: there is still a kernel oops there in a
corner case when loading the ivtv driver that I need to fix first.

The first tree has slightly older (but almost identical) code and a
converted ivtv driver that you can look at. Most important are the files
Documentation/video4linux/v4l2-framework.txt that explains the new structs
and the v4l2-device.h and v4l2-subdev.h headers.

Note that there are currently no sensor support ops in v4l2-subdev.h. This
will have to be added (should be trivial).

> Again I would like to know, how are we handling current drivers
> (soc-camera and v4l2-int)?

soc-camera and v4l2-int are the exceptions. All other drivers use the i2c
command function to communicate with i2c drivers (ioctl-like API).

Just a note on soc-camera: it's only the soc_camera_ops struct that I want
to see replaced (eventually) by v4l2_subdev. What I want is that subdevice
drivers like tvp514x, but also sensor drivers like mt9xxxx should be
independent of the host (bridge) driver. That way they can be reused
properly. For example, having the mt9m001.c driver use soc_camera makes it
much harder to use with e.g. a USB webcam driver which is not based on the
soc_camera framework.

Regards,

       Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux