Re: Please fix lcd_sx1.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 23, 2008 at 04:46:18PM +0000, Russell King - ARM Linux wrote:
> To me, it looks like this driver was tossed over into mainline without
> any thought - it has never been in a buildable state.  Please fix or
> remove this driver from mainline.

Actually, it was buildable, until this commit:

commit b4b58f5834a023dab67201db9a626bef07bb200c
Author: Chandra Shekhar <x0044955@xxxxxx>
Date:   Wed Oct 8 10:01:39 2008 +0300

    ARM: OMAP: Allocate McBSP devices dynamically
    
    Based on Chandra's earlier patches in linux-omap tree.
    
    Note that omap1_mcbsp_check and omap2_mcbsp_check are no longer
    needed as there's now omap_mcbsp_check_valid_id() defined.
    
    Also some functions can now be marked __init.
    
    Signed-off-by: Chandra Shekhar <x0044955@xxxxxx>
    Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

which means it's a regression and therefore needs fixing before 2.6.28.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux