Re: [PATCH 2/2] OMAP2/3 GPTIMER: skip unnecessary TLDR write during non-autoreload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Woodruff, Richard <r-woodruff2@xxxxxx> [081121 14:53]:
> > * Woodruff, Richard <r-woodruff2@xxxxxx> [081014 12:47]:
> > > >       omap_dm_timer_write_reg(timer, OMAP_TIMER_COUNTER_REG, load);
> > > > -     omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
> > > >       omap_dm_timer_write_reg(timer, OMAP_TIMER_CTRL_REG, l);
> > > >  }
> > >
> > > I seem to recall there was a missed interrupt condition which this worked
> > around.
> > >
> > > IIRC, the original code didn't bother with the load I added back as a work
> > around as a way to get posted mode working.
> >
> > Well these seem to be working based on some quick timer tests.
> > Pushing so we can verify it ;)
> 
> This kind of change might be better tested on the PM branch.  It's the kind of thing more likely to work with PM disabled.  Testing in both is good, PM for many things is less forgiving...

OK, let's not push them yet then. Kevin promised to run some timer
tests on them on Monday, so let's wait for that.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux