On Friday 21 November 2008, Trilok Soni wrote: > > + > > +static int > > +tvp514x_probe(struct i2c_client *client, const struct i2c_device_id *id) > > +{ > > Mark this as __init please. No, don't. It's for an I2C device ... which means it needs to stay hotpluggable. There are *very* few places it's correct to mark probe() methods as __init, or even __devinit, and this isn't one of those exceptions. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html