----- Original Message -----
From: "Misael Lopez" <mesak82@xxxxxxxxx>
To: "Gadiyar, Anand" <gadiyar@xxxxxx>
Cc: <linux-omap@xxxxxxxxxxxxxxx>; "Pandita, Vikram" <vikram.pandita@xxxxxx>
Sent: Friday, November 21, 2008 11:55 AM
Subject: Re: [PATCH][OMAPZOOM] OMAP3: Fix handling of McBSP registers XCCR and
RCCR for OMAP2430/34xx
> @@ -403,8 +408,10 @@ struct omap_mcbsp_reg_cfg {
> u16 rcerh;
> u16 xcerg;
> u16 xcerh;
> +#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
> u16 xccr;
> u16 rccr;
> +#endif
> };
Won't this cause a compilation break on non-2430/34xx platforms
because you refer to these variables below?
True... I didn't consider that. Then for non-2430/34xx platforms,
having those registers in the structure but avoiding to write to them
is enough, correct? or any other alternative?
Since you write those registers conditionally for 2430/34xx, i guess removing
ifdef should do..
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
