On Tue, Nov 18, 2008 at 09:15:34AM -0800, David Brownell wrote: > On Tuesday 18 November 2008, Felipe Balbi wrote: > > > +#define OMAP2_MCSPI_SYSCONFIG_SMARTIDLE (0x2 << 3) > > > +#define OMAP2_MCSPI_SYSCONFIG_ENAWAKEUP (0x1 << 2) > > > > could you follow the convention below and use (1 << offset) ?? > > Or even BIT(offset). much better :-) -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html